[Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

[Zachary Turner via lldb-commits]

zturner added a comment.

If you change the name back to `ResolveSymbolicLink` or `GetSymbolicLinkTarget`, then this looks fine.


================
Comment at: include/lldb/Host/FileSystem.h:43
@@ -42,1 +42,3 @@
+    
+    static Error Realpath(const FileSpec &src, FileSpec &dst);
 
----------------
I'd rather not call it realpath, because even though realpath is the way it will be implemented on non-Windows platforms, realpath has some subtleties in its semantics.  So anyone reading this function name will expect that it has realpath semantics, even though some of the semantics are only well-defined in the context of a posix-like file system.  I actually like your original name `ResolveSymbolicLink` better, because the behavior is narrow enough that it's easy to implement everywhere, and we don't have to worry about these little edge cases.


http://reviews.llvm.org/D12984