[Lldb-commits] [PATCH] D12980: Have a clean(er) shutdown when detaching from processes
Adrian McCarthy via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 18 13:36:04 PDT 2015
amccarth accepted this revision.
This revision is now accepted and ready to land.
================
Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:309
@@ -308,1 +308,3 @@
{
+ if (m_pid_to_detach != 0 && dbe.u.Exception.ExceptionRecord.ExceptionCode == EXCEPTION_BREAKPOINT) {
+ WINLOG_IFANY(WINDOWS_LOG_EVENT | WINDOWS_LOG_EXCEPTION | WINDOWS_LOG_PROCESS,
----------------
Open brace goes on the next line. (Which appears to have originally been my mistake. Sorry.)
================
Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:316
@@ -309,1 +315,3 @@
+ }
+
// Don't perform any blocking operations while we're shutting down. That will
----------------
This is fine, but I'm growing concerned about the growing spaghetti-ness. It's too bad we can't push this logic down into HandleExceptionEvent, in order to keep the cases in this deeply-nested switch statement easy to understand.
http://reviews.llvm.org/D12980
More information about the lldb-commits
mailing list