[Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

[Zachary Turner via lldb-commits]

Just a drive by comment since I don't have a vested interest in lldb-server
or this CL at the moment.  But adding lldb-server as a dependency of lldb
seems strange to me.  I mean I get it, it just seems strange.  They're not
really dependencies in the normal sense.  If you just use "ninja" instead
of "ninja lldb" you should get both targets, while still allowing "ninja
lldb" to only build lldb, as it currently does.

Up to you guys though

On Wed, Sep 16, 2015 at 7:48 AM Todd Fiala via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> tfiala added a comment.
>
> > Okay I'll make an adjustment to turn it on for Darwin and setting it
> based on a flag.
>
>
> I'm going to do it slightly differently --- I'll set a flag in the modules
> config that indicates if lldb *wants* lldb-server.  The logic on whether to
> build it or not should, as before, be driven by the targets asked for.  So
> we're not really setting whether we build it or not, we're setting whether
> we want it if we're already building lldb.
>
>
> http://reviews.llvm.org/D12899
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150916/f455a524/attachment.html>