[Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

[Dawn Perchik via lldb-commits]

dawn added a comment.

In http://reviews.llvm.org/D12115#244049, @zturner wrote:

> The FileSpec is not even used for anything is it?


No, that was a carry over from a previous patch - now deleted.

> If you want to use the

>  RegularExpression, then use llvm's regular expression.  Honestly LLDB's

>  regular expression should be deprecated anyway, there's no reason to have

>  an LLDB regex and an LLVM regex when just one will suffice


I agree.

But for now, I've written a small regex wrapper for lldb-mi based on llvm's C regex implementation which uses lldb-mi's string types.  It would be awesome to replace lldb-mi's types with those of llvm someday (e.g. have CMIUtilString use StringRef instead of std::string, etc), so that it would be easier to use llvm's classes.


Repository:
  rL LLVM

http://reviews.llvm.org/D12115