[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

[Greg Clayton via lldb-commits]

clayborg added a comment.

We only really need variable to inherit from std::shared_from_this if we have any classes or API that use a "Variable *" as ivars or parameters. If we do, feel free to make it inherit from shared_from_this, but I would like to avoid it if possible to save on space. Also if you convert to shared_from_this, all construction of Variables must be done into shared pointers directly as they are constructed or things will crash.


http://reviews.llvm.org/D12658