[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

I believe you have addressed all of my concerns. Read through my previous comments and make sure, and if so, this is good to go. Nice patch, thanks for working through the abtracting issues we ran into and for making a great patch.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3883-3884
@@ +3882,4 @@
+                    {
+                        lldb::user_id_t spec_uid = form_value.Reference();
+                        if (UserIDMatches(spec_uid))
+                        {
----------------
Per tberghammer's comment we might need to add a way to get a DIERef from a DWARFFormValue...


http://reviews.llvm.org/D12658