[Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just can't check for zero in SymbolFileDWARF, other than that it looks good.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248
@@ -2241,2 +2241,9 @@
         lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd (0);
+
+        // lowest_func_addr is a file address what can't be 0 because at address 0 we should have the
+        // file header. It is 0 if the linker optimized out the given function when we don't want to
+        // return an invalid function object.
+        if (lowest_func_addr == 0)
+            return nullptr;
+
         if (lowest_func_addr != LLDB_INVALID_ADDRESS && lowest_func_addr <= highest_func_addr)
----------------
This actually can be zero for functions in a .o file. So this must be removed or you must fix it in a different way. 


http://reviews.llvm.org/D12804