[Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

[Todd Fiala via lldb-commits]

Author: tfiala
Date: Mon Sep 14 11:25:34 2015
New Revision: 247576

URL: http://llvm.org/viewvc/llvm-project?rev=247576&view=rev
Log:
Cleaned up a few unexpected successes on OS X

TestCallStdStringFunction
TestCallWithTimeout
TestConstVariables
TestClassTypes

Modified:
    lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
    lldb/trunk/test/expression_command/timeout/TestCallWithTimeout.py
    lldb/trunk/test/lang/c/const_variables/TestConstVariables.py
    lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py

Modified: lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py?rev=247576&r1=247575&r2=247576&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py (original)
+++ lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py Mon Sep 14 11:25:34 2015
@@ -20,7 +20,6 @@ class ExprCommandCallFunctionTestCase(Te
 
     @skipUnlessDarwin
     @dsym_test
-    @expectedFailureDarwin(16361880) # <rdar://problem/16361880>, we get the result correctly, but fail to invoke the Summary formatter.
     def test_with_dsym(self):
         """Test calling std::String member function."""
         self.buildDsym()
@@ -29,7 +28,6 @@ class ExprCommandCallFunctionTestCase(Te
     @dwarf_test
     @expectedFailureFreeBSD('llvm.org/pr17807') # Fails on FreeBSD buildbot
     @expectedFailureIcc # llvm.org/pr14437, fails with ICC 13.1
-    @expectedFailureDarwin(16361880) # <rdar://problem/16361880>, we get the result correctly, but fail to invoke the Summary formatter.
     @expectedFailureWindows("llvm.org/pr21765")
     def test_with_dwarf(self):
         """Test calling std::String member function."""

Modified: lldb/trunk/test/expression_command/timeout/TestCallWithTimeout.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/timeout/TestCallWithTimeout.py?rev=247576&r1=247575&r2=247576&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/timeout/TestCallWithTimeout.py (original)
+++ lldb/trunk/test/expression_command/timeout/TestCallWithTimeout.py Mon Sep 14 11:25:34 2015
@@ -21,7 +21,6 @@ class ExprCommandWithTimeoutsTestCase(Te
 
     @skipUnlessDarwin
     @dsym_test
-    @expectedFailureDarwin # failed 1/134 runs, line 83, value.IsValid() 
     def test_with_dsym(self):
         """Test calling std::String member function."""
         self.buildDsym()

Modified: lldb/trunk/test/lang/c/const_variables/TestConstVariables.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/c/const_variables/TestConstVariables.py?rev=247576&r1=247575&r2=247576&view=diff
==============================================================================
--- lldb/trunk/test/lang/c/const_variables/TestConstVariables.py (original)
+++ lldb/trunk/test/lang/c/const_variables/TestConstVariables.py Mon Sep 14 11:25:34 2015
@@ -11,13 +11,12 @@ class ConstVariableTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @dsym_test
-    @unittest2.expectedFailure(13314878)
     def test_with_dsym_and_run_command(self):
         """Test interpreted and JITted expressions on constant values."""
         self.buildDsym()
         self.const_variable()
 
-    @expectedFailureClang('13314878') # This test works with gcc, but fails with newer version of clang on Linux due to a clang issue. Fails for icc as well. Bug number TDB.
+    @expectedFailureAll(oslist=["linux"], compiler=["clang", "icc"])
     @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @expectedFailureWindows("llvm.org/pr24490: We shouldn't be using platform-specific names like `getpid` in tests")
     @dwarf_test

Modified: lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py?rev=247576&r1=247575&r2=247576&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py (original)
+++ lldb/trunk/test/lang/cpp/class_types/TestClassTypes.py Mon Sep 14 11:25:34 2015
@@ -63,7 +63,6 @@ class ClassTypesTestCase(TestBase):
     # rdar://problem/8557478
     # test/class_types test failures: runCmd: expr this->m_c_int
     @dsym_test
-    @expectedFailureDarwin(16362674)
     def test_with_dsym_and_constructor_name(self):
         """Test 'frame variable this' and 'expr this' when stopped inside a constructor."""
         self.buildDsym()
@@ -73,7 +72,6 @@ class ClassTypesTestCase(TestBase):
     # test/class_types test failures: runCmd: expr this->m_c_int
     @dwarf_test
     @expectedFailureFreeBSD('llvm.org/pr14540')
-    @expectedFailureDarwin(16362674)
     def test_with_dwarf_and_constructor_name (self):
         """Test 'frame variable this' and 'expr this' when stopped inside a constructor."""
         self.buildDwarf()