[Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D12651#240423, @zturner wrote:

> Ctrl+C once doesn't work on Windows with this patch.  It seems to continue starting up new processes, and after all of them are done, I'm left with the original set of Python processes not doing any work, just sitting there.  If I Ctrl+C again everything does.


Okay.  So its like the first Ctrl-C is essentially not even handled, but the second Ctrl-C does the nuclear option and kills everything.  Is that right?

> Note that when I press the first Ctrl+C, I don't even get the print that says First Keyboard Interrupt received.


That kinda sounds like these lines might be suspect:

  # Shut off interrupt handling in the child process.
  signal.signal(signal.SIGINT, signal.SIG_IGN)

(at line 224-225).  If they're not doing anything on Windows, then it is possible that the Ctrl-C could get gobbled by one of the child multiprocessing workers (?)

I'll dig around and see if there's something different about how Windows handles disabling Ctrl-C.  (If you know anything there, that'd be helpful as well).

Worst case we could check os type and skip the soft kill on NT?


http://reviews.llvm.org/D12651