[Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

[Todd Fiala via lldb-commits]

> Now there is no equivelent to "dosep.py -s", and:
>    ./dotest.py -v --executable $INSTALLDIR/bin/lldb

All of dosep's args moved over to dotest.  I think if you wanted dosep.py
-s behavior, you only need to use --output-on-success (long form of what
used to be -s in dosep I believe).  The reason I couldn't maintain it as -s
is that dotest.py already had a -s abbreviation (for session dir
specification).

On Fri, Sep 4, 2015 at 12:02 PM, <dawn at burble.org> wrote:

> On Fri, Sep 04, 2015 at 06:25:44PM +0000, Todd Fiala wrote:
> > tfiala added a comment.
> >
> > Dawn, the output supported by the command shouldn't have been changed.
> I'll have a peek at what may have caused that to happen.  All this change
> was trying to do was stop the need to call dosep and roll that behavior
> into dotest.
>
> Both of these commands:
>     ./dosep.py -s --options "-v --executable $INSTALLDIR/bin/lldb"
>     ./dotest.py -v --executable $INSTALLDIR/bin/lldb
>
> used to print results like the following:
>     Collected 6 tests
>
>     1: test_double_type_from_block_with_dsym
>     (TestFloatTypes.FloatTypesTestCase)
>     Test that double-type variables are displayed correctly from a
>     block. ... ok
>     2: test_double_type_with_dsym (TestFloatTypes.FloatTypesTestCase)
>     Test that double-type variables are displayed correctly. ... ok
>     3: test_double_type_with_dwarf (TestFloatTypes.FloatTypesTestCase)
>     Test that double-type variables are displayed correctly. ... ok
>     4: test_float_type_from_block_with_dsym
>     (TestFloatTypes.FloatTypesTestCase)
>     Test that float-type variables are displayed correctly from a block.
>     ... ok
>     5: test_float_type_with_dsym (TestFloatTypes.FloatTypesTestCase)
>     Test that float-type variables are displayed correctly. ... ok
>     6: test_float_type_with_dwarf (TestFloatTypes.FloatTypesTestCase)
>     Test that float-type variables are displayed correctly. ... ok
>
>     ----------------------------------------------------------------------
>     Ran 6 tests in 6.844s
>
>     RESULT: PASSED (6 passes, 0 failures, 0 errors, 0 skipped, 0
>             expected failures, 0 unexpected successes)
>
>     [TestFloatTypes.py PASSED]
>
> Now there is no equivelent to "dosep.py -s", and:
>     ./dotest.py -v --executable $INSTALLDIR/bin/lldb
>
> prints results like the following:
>     Testing: 395 test suites, 8 threads
>
>     0 out of 395 test suites processed - ['./dotest.py', '-v',
>     '--executable',
>
> '/Users/testuser/build/workspace/LLVM-Clang-LLDB_master_release_OSX/llvm/build_ninja/lldb_redist/usr/local/bin/lldb']
>
>         1 out of 395 test suites processed -
> TestCompileRunToBreakpointTurnaround.py
>         [...]
>     395 out of 395 test suites processed - TestRecursiveTypes.py
>     Ran 395 test suites (0 failed) (0.000000%)
>     Ran 826 test cases (0 failed) (0.000000%)
>
> So we no longer have info on what tests ran, can't figure out what
> tests were skipped, can't calculate the correct totals, etc.
>



-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150904/690acfde/attachment.html>