[Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

[Zachary Turner via lldb-commits]

To be honest I think grepping the output is the wrong way to go about
counting the tests.

If there's a regression in that you no longer have access to a piece of
information that you need, then we should fix it by printing the value you
need.  Log scraping is kind of a horrible thing to do, because it means you
are going to be broken by changes to the format of the output, and it will
hold back progress on the test suite making real improvements in
maintainability and performance because all the different people doing
their own custom log scraping will get upset if anything breaks.

Anyone who has worked on the test suite can vouch for the fact that it is
in need of some major love, and if that means a transition period where
things are a little wonky, and we lose some things only to get them back
later, I'm ok with that.

On Fri, Sep 4, 2015 at 11:04 AM Dawn Perchik via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> dawn added a comment.
>
> I really liked that dosep.py -s and dotest.py would report the run of each
> test case:
>
>   Collected 6 tests
>
>   1: test_double_type_from_block_with_dsym
> (TestFloatTypes.FloatTypesTestCase)
>   Test that double-type variables are displayed correctly from a block.
> ... ok
>   2: test_double_type_with_dsym (TestFloatTypes.FloatTypesTestCase)
>   Test that double-type variables are displayed correctly. ... ok
>   3: test_double_type_with_dwarf (TestFloatTypes.FloatTypesTestCase)
>   Test that double-type variables are displayed correctly. ... ok
>   4: test_float_type_from_block_with_dsym
> (TestFloatTypes.FloatTypesTestCase)
>   Test that float-type variables are displayed correctly from a block. ...
> ok
>   5: test_float_type_with_dsym (TestFloatTypes.FloatTypesTestCase)
>   Test that float-type variables are displayed correctly. ... ok
>   6: test_float_type_with_dwarf (TestFloatTypes.FloatTypesTestCase)
>   Test that float-type variables are displayed correctly. ... ok
>
>   ----------------------------------------------------------------------
>   Ran 6 tests in 6.844s
>
>   RESULT: PASSED (6 passes, 0 failures, 0 errors, 0 skipped, 0 expected
> failures, 0 unexpected successes)
>
>   [TestFloatTypes.py PASSED]
>
> I would like to have that back please.
>
>
> Users:
>   tfiala (Author)
>   dawn (Auditor)
>
> http://reviews.llvm.org/rL246794
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150904/8602ab51/attachment.html>