[Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

[Jim Ingham via lldb-commits]

If the user says "break set -a <SOME ADDRESS>" I have no problem with our setting the breakpoint there even if we don't think it is a terribly good idea.  But if lldb is converting any other specification to an address, it should always move past data in text.  The failure modes if you aren't careful about this are really confusing: "Why was the first value in my enum whatever the trap instruction is on your platform..." etc...  If allowing the former makes it hard to do the latter, the latter should have priority.

Jim



> On Sep 4, 2015, at 9:11 AM, Tamas Berghammer via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> tberghammer updated this revision to Diff 34038.
> tberghammer added a comment.
> 
> Updated the change based on the comments.
> 
> I don't fully agree with restricting the user from setting breakpoint in non-code locations because if LLDB classified a section incorrectly (e.g. haven't found the SO file for it) the user might want to still set a breakpoint there. In general I would like to make it possible to set a breakpoint at any address (even on un-aligned ones) but warn the user that it might be incorrect.
> 
> 
> http://reviews.llvm.org/D12556
> 
> Files:
>  include/lldb/Core/Address.h
>  source/API/SBFrame.cpp
>  source/Core/Address.cpp
>  source/Target/StackFrame.cpp
>  source/Target/StackFrameList.cpp
> 
> <D12556.34038.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits