[Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 3 02:31:31 PDT 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL246753: Fix rare failure in TestProcessIO (authored by labath).

Changed prior to commit:
  http://reviews.llvm.org/D12558?vs=33815&id=33917#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D12558

Files:
  lldb/trunk/source/Target/Process.cpp

Index: lldb/trunk/source/Target/Process.cpp
===================================================================
--- lldb/trunk/source/Target/Process.cpp
+++ lldb/trunk/source/Target/Process.cpp
@@ -1479,12 +1479,7 @@
     else
         m_exit_string.clear();
 
-    // When we exit, we no longer need to the communication channel
-    m_stdio_communication.Disconnect();
-    m_stdio_communication.StopReadThread();
-    m_stdin_forward = false;
-
-    // And we don't need the input reader anymore as well
+    // When we exit, we don't need the input reader anymore
     if (m_process_input_reader)
     {
         m_process_input_reader->SetIsDone(true);
@@ -4159,6 +4154,10 @@
         case eStateExited:
         case eStateUnloaded:
             m_stdio_communication.SynchronizeWithReadThread();
+            m_stdio_communication.Disconnect();
+            m_stdio_communication.StopReadThread();
+            m_stdin_forward = false;
+
             // fall-through
         case eStateConnected:
         case eStateAttaching:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12558.33917.patch
Type: text/x-patch
Size: 1036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150903/19d756aa/attachment.bin>


More information about the lldb-commits mailing list