[Lldb-commits] [lldb] r246667 - Removed comments that suggested that asserts in the ClangASTImporter should be

Sean Callanan via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 2 09:40:59 PDT 2015


Author: spyffe
Date: Wed Sep  2 11:40:59 2015
New Revision: 246667

URL: http://llvm.org/viewvc/llvm-project?rev=246667&view=rev
Log:
Removed comments that suggested that asserts in the ClangASTImporter should be
debug-only.  This is not the case; when they fire we are about to crash or do
something horrible anyway, so they should stay in.

Modified:
    lldb/trunk/source/Symbol/ClangASTImporter.cpp

Modified: lldb/trunk/source/Symbol/ClangASTImporter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTImporter.cpp?rev=246667&r1=246666&r2=246667&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTImporter.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTImporter.cpp Wed Sep  2 11:40:59 2015
@@ -607,7 +607,7 @@ void
 ClangASTImporter::Minion::InitDeportWorkQueues (std::set<clang::NamedDecl *> *decls_to_deport,
                                                 std::set<clang::NamedDecl *> *decls_already_deported)
 {
-    assert(!m_decls_to_deport); // TODO make debug only
+    assert(!m_decls_to_deport);
     assert(!m_decls_already_deported);
     
     m_decls_to_deport = decls_to_deport;
@@ -617,7 +617,7 @@ ClangASTImporter::Minion::InitDeportWork
 void
 ClangASTImporter::Minion::ExecuteDeportWorkQueues ()
 {
-    assert(m_decls_to_deport); // TODO make debug only
+    assert(m_decls_to_deport);
     assert(m_decls_already_deported);
     
     ASTContextMetadataSP to_context_md = m_master.GetContextMetadata(&getToContext());




More information about the lldb-commits mailing list