[Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

[Pavel Labath via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, ovyalov.
labath added a subscriber: lldb-commits.

There was a race condition in the AsyncThread, where we would end up sending a vAttach
notification to the thread before it got a chance set up its listener (this can be reproduced by
adding a sleep() at the very beginning of ProcessGDBRemote::AsyncThread()). This event would then
get lost and we LLDB would deadlock. I fix this by setting up the listener early on, in the
ProcessGDBRemote constructor.

This should improve the stability of all attach tests. For now, I am removing XTIMEOUT from
TestAttachResume, and will watch the buildbots for signs of trouble.

http://reviews.llvm.org/D12552

Files:
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  test/dosep.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12552.33795.patch
Type: text/x-patch
Size: 23259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150902/8f96ebdd/attachment-0001.bin>