[Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

[Zachary Turner via lldb-commits]

zturner accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:249-252
@@ -240,3 +248,6 @@
 {
-    // TODO
-    return 0;
+    // I don't have a sense of how frequently this is called or how many memory
+    // ranges a mini dump typically has, so I'm not sure if searching for the
+    // appropriate range linearly each time is stupid.  Perhaps we should build
+    // an index for faster lookups.
+    Range range = {0};
----------------
Yea, a lazily constructed index seems like it would be a good idea.  For those dumps which don't contain full heap information this will probably be pretty quick, but if a dump has full heap information this is going to be a huge slowdown.

Not something we have to worry about right now, but we'll need to address it eventually.


http://reviews.llvm.org/D12507