[Lldb-commits] [PATCH] D12531: Fix tab completion for command arguments containing spaces

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 1 07:40:24 PDT 2015


labath added inline comments.

================
Comment at: source/Interpreter/Options.cpp:996
@@ +995,3 @@
+        {
+            if (c == ' ' || c == '\\')
+                s.push_back('\\');
----------------
If there is any chance quotes will appear here (', ", `), you will need to escape those as well, as they are special to the command interpreter. It might be worth making a utility function out of that (Args::GetCommandInterpreterSafeArgument ?), as a canonical way to escape stuff.


http://reviews.llvm.org/D12531





More information about the lldb-commits mailing list