[Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

[Sagar Thakur via lldb-commits]

sagar marked 7 inline comments as done.

================
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3160
@@ +3159,3 @@
+                if((*ptr == 0 && bnz) || (*ptr != 0 && !bnz) )
+                    branch_hit = false;
+                break;
----------------
The former one is more readable.

================
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3187
@@ +3186,3 @@
+    context.type = eContextRelativeBranchImmediate;
+
+    if (!WriteRegisterUnsigned (context, eRegisterKindDWARF, gcc_dwarf_pc_mips64, target))
----------------
I have set the type to eContextRelativeBranchImmediate for now we are using these instructions for single stepping only.

================
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3230
@@ +3229,3 @@
+    else
+        target = pc + 8;
+
----------------
The former one is more readable.

================
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3236
@@ +3235,3 @@
+    if (!WriteRegisterUnsigned (context, eRegisterKindDWARF, gcc_dwarf_pc_mips64, target))
+        return false;
+
----------------
I have set the type to eContextRelativeBranchImmediate for now we are using these instructions for single stepping only.


Repository:
  rL LLVM

http://reviews.llvm.org/D12356