[Lldb-commits] [PATCH] D12363: Read module list from mini dump

[Zachary Turner via lldb-commits]

zturner added inline comments.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:57-63
@@ +56,9 @@
+    const auto length_required =
+        ::WideCharToMultiByte(CP_UTF8, 0, md_string->Buffer, md_string->Length,
+                              nullptr, 0, nullptr, nullptr);
+    result.resize(length_required);
+    const auto actual_length =
+        ::WideCharToMultiByte(CP_UTF8, 0, md_string->Buffer, md_string->Length,
+                              &result[0], static_cast<int>(result.size()),
+                              nullptr, nullptr);
+    result.resize(actual_length);
----------------
Can this use the functions in llvm/Support/ConvertUTF.h?


http://reviews.llvm.org/D12363