[Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

[Dawn Perchik via lldb-commits]

dawn added a subscriber: dawn.
dawn added a comment.

Hi Greg,

While I really appreciate that you're making lldb less Clang specific (e.g. renaming ClangASTType to CompilerType), I'm concerned about this commit because it moves DWARF knowledge from the SymbolFileDWARF plugin into ClangASTContext.cpp, making it impossible to support other debug formats as plugins.

I realize some DWARF had leaked outside of the DWARF plugin before this commit (like the enums for language and calling convention), but those could easily be converted to/from other debug formats.  This new code really requires that the debug info be DWARF.

Am I missing something?
Thanks in advance, -Dawn


http://reviews.llvm.org/rL245090