[Lldb-commits] [lldb] r246123 - Silence some MSVC warnings.

[Stephane Sezer via lldb-commits]

Author: sas
Date: Wed Aug 26 18:55:14 2015
New Revision: 246123

URL: http://llvm.org/viewvc/llvm-project?rev=246123&view=rev
Log:
Silence some MSVC warnings.

Summary:
Just `assert("string" && false)` instead of `assert("string" == NULL)`.

This avoid errors like

    [...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation on address of string constant

Reviewers: zturner

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D12388

Modified:
    lldb/trunk/source/Core/SourceManager.cpp

Modified: lldb/trunk/source/Core/SourceManager.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/SourceManager.cpp?rev=246123&r1=246122&r2=246123&view=diff
==============================================================================
--- lldb/trunk/source/Core/SourceManager.cpp (original)
+++ lldb/trunk/source/Core/SourceManager.cpp Wed Aug 26 18:55:14 2015
@@ -644,14 +644,14 @@ SourceManager::File::CalculateLineOffset
         else
         {
             // Some lines have been populated, start where we last left off
-            assert("Not implemented yet" == NULL);
+            assert("Not implemented yet" && false);
         }
 
     }
     else
     {
         // Calculate all line offsets up to "line"
-        assert("Not implemented yet" == NULL);
+        assert("Not implemented yet" && false);
     }
     return false;
 }