[Lldb-commits] [PATCH] D9703: Adds support for ARM hardware watchpoints

[Muhammad Omair Javaid via lldb-commits]

omjavaid updated this revision to Diff 33075.
omjavaid added a comment.

This updated patches correct problems in arm hardware watchpoint support patch posted earlier.

This patch has been tested on samsung chromebook (ARM - Linux) and PandaBoard using basic watchpoint test application.

Also it was tested on Nexus 7 Android device.

On chromebook linux we are able to set and clear all types of watchpoints but on android we end up getting a watchpoint packet error because we are not able to call hardware watchpoint ptrace functions successfully.

I still dont have a android device on me that has hardware watchpoints enable but fact that this functionality now works on linux means that we should get this into our source code.

I am trying to write a test to check hardware watchpoint capabilities of a platform so we are pretty sure what works on which platform.

Is this good to commit?


http://reviews.llvm.org/D9703

Files:
  source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
  source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9703.33075.patch
Type: text/x-patch
Size: 17848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150825/368f1d13/attachment.bin>