[Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot

[Bhushan Attarde via lldb-commits]

bhushan updated this revision to Diff 33063.
bhushan added a comment.

Addressed review comments.

1. Introduced Target::GetBreakableLoadAddress() instead of Target::AdjustBreakpointInDelaySlot() so that it should look more generic and targets can calculate the new breakpoint address based on whatever reason applicable to them (not restricting it to a delay-slot only).

2. Target::GetBreakableLoadAddress() does not do any work unless a target requires it.

3. Logging is enabled (under the breakpoint channel) and now mentions a reason why we changed the original breakpoint address. (In case of MIPS, the reason is a delay slot).


Repository:
  rL LLVM

http://reviews.llvm.org/D12184

Files:
  include/lldb/Core/Disassembler.h
  include/lldb/Target/Target.h
  source/Core/Disassembler.cpp
  source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
  source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h
  source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12184.33063.patch
Type: text/x-patch
Size: 13889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150825/4a35fc14/attachment.bin>