[Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

[Dawn Perchik via lldb-commits]

dawn added a comment.

In http://reviews.llvm.org/D12303#231759, @ted wrote:

> This is essentially reverting http://reviews.llvm.org/rL237053 , so we'd go back to the problem with it - LLDB won't be able to set the platform based on the architecture in the target binary, but will use the currently selected platform, even if it's not compatible.


Hmm.   Looking at test test_disassemble_invalid_vst_1_64_raw_data, this appeared to be intentional since it does:

  target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "thumbv7")

and expects the target arch to be set from that.  There are a couple other tests which are setting the arch manually like this also.  It's certainly possible that the test cases are wrong.  Should I replace this patch with skips for those tests?

> So platform_sp will always be true, unless LLDB doesn't have a current (or default host) platform.


Exactly.  Again, this looked intentional.  Hmm.

> What error is causing the tests to fail?


Please see my comment at http://reviews.llvm.org/rL237053.  On OSX, all you see is ERROR and nothing else.


Repository:
  rL LLVM

http://reviews.llvm.org/D12303