[Lldb-commits] [PATCH] D12290: Handle DW_OP_GNU_addr_index in DWARF expressions

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks good.

DWARFExpression is unique in that it is separate from the DWARF plug-in itself because DWARF expressions are in .eh_frame and other things that don't require the rest of DWARF.  It would be nice to not pass a DWARFCompileUnit to DWARFExpression, but then we would need to abstract everything we needed from DWARFCompileUnit into lldb_private::CompileUnit and the things we get from the DWARFCompileUnit are not things we want in the lldb_private::CompileUnit API, so this is the right solution.


http://reviews.llvm.org/D12290