[Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

Chaoren Lin via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 14 16:24:19 PDT 2015

chaoren accepted this revision.
This revision is now accepted and ready to land.

Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
+def skipUnlessArch(archlist):
+    def myImpl(func):
zturner wrote:
> chaoren wrote:
> > Is there a reason
> > ```
> > return unittest2.skipUnless(getArchitecture() in archlist, ...)
> > ```
> > is not sufficient?
> > 
> > Also, please add a doc string, like the other skip{If,Unless} methods.
> `getArchitecture()` is a member of `self`, which is not defined here.  TBH this stuff is beyond my Python level, I tried simpler versions but this is how I ultimately got it working after seeing what some of the other decorators did.
Okay. I see what you mean. LGTM for now (if it works), I'll add a change later to unittest2.skip* to allow a callback that takes a test_item, instead of just a condition.


More information about the lldb-commits mailing list