[Lldb-commits] [PATCH] D12043: Convert all use of pthreads in test executables to std threads

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 14 15:21:04 PDT 2015


zturner created this revision.
zturner added reviewers: clayborg, jingham.
zturner added a subscriber: lldb-commits.

This eliminates portability issues among platforms that don't have a pthreads implementation.

There was one situation in TestTlsGlobals.py where it seems the intention is to compile the executable with C.  In that case I left it alone, and we will need to eventually provide a windows-based implementation of that test.  But for tests which don't explicitly require pure C for the test, I don't see a good reason not to use std threads across the board.

http://reviews.llvm.org/D12043

Files:
  test/functionalities/expr-doesnt-deadlock/Makefile
  test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py
  test/functionalities/expr-doesnt-deadlock/locking.c
  test/functionalities/expr-doesnt-deadlock/locking.cpp
  test/functionalities/thread/create_during_step/main.cpp
  test/functionalities/thread/exit_during_break/main.cpp
  test/functionalities/thread/exit_during_step/main.cpp
  test/functionalities/thread/multi_break/main.cpp
  test/functionalities/thread/step_out/main.cpp
  test/functionalities/thread/thread_exit/main.cpp
  test/functionalities/thread/thread_specific_break/Makefile
  test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py
  test/functionalities/thread/thread_specific_break/main.c
  test/functionalities/thread/thread_specific_break/main.cpp
  test/lang/c/tls_globals/TestTlsGlobals.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12043.32194.patch
Type: text/x-patch
Size: 21266 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150814/925ea72c/attachment-0001.bin>


More information about the lldb-commits mailing list