[Lldb-commits] [PATCH] D11843: Make dosep output status by	overwriting the same line.
    Chaoren Lin via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Wed Aug 12 10:55:43 PDT 2015
    
    
  
chaoren added inline comments.
================
Comment at: test/dosep.py:163
@@ -162,3 @@
-        # We're only interested in the test file with the "Test*.py" naming pattern.
-        if not name.startswith("Test") or not name.endswith(".py"):
-            continue
----------------
From here.
================
Comment at: test/dosep.py:215
@@ +214,3 @@
+            # Only interested in test files with the "Test*.py" naming pattern.
+            return name.startswith("Test") and name.endswith(".py")
+
----------------
zturner wrote:
> How was this working before?  Seems risky to start eliminating files that were previously considered, and is this rule documented anywhere that the filename must start with Test?
Yeah, this is moved over from line 163. I just moved the filtering earlier to get a count of test suites.
http://reviews.llvm.org/D11843
    
    
More information about the lldb-commits
mailing list