[Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

Jaydeep Patil via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 12 02:17:15 PDT 2015


jaydeep added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2498-2500
@@ +2497,5 @@
+                    reason = "watchpoint";
+                    std::ostringstream ostr;
+                    ostr << wp_addr << " " << wp_index;
+                    description = ostr.str();
+                }
----------------
clayborg wrote:
> Not sure if you need to do this, try not setting this and see how the description comes out. The watchpoint stop info should set this correctly?
We need "watchpoint" in the description so that SetThreadStopInfo can create CreateStopReasonWithWatchpointID.
 


Repository:
  rL LLVM

http://reviews.llvm.org/D11747





More information about the lldb-commits mailing list