[Lldb-commits] [PATCH] D11935: Fetch SDK version from PlatformAndroid

[Oleksiy Vyalov via lldb-commits]

ovyalov added a comment.

Please see my comments.


================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:284
@@ +283,3 @@
+    std::string version_string;
+    RunShellCommand("getprop ro.build.version.sdk",
+                    GetWorkingDirectory(),
----------------
Could you check for error that RunShellCommand returns?

================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:290
@@ +289,3 @@
+                    1);
+    m_sdk_version = ::atoi(version_string.c_str());
+    return m_sdk_version;
----------------
StringConvert::ToUInt32 ?


http://reviews.llvm.org/D11935