[Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target
Jaydeep Patil via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 10 23:20:53 PDT 2015
jaydeep added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1463-1465
@@ +1462,5 @@
+ // If we don't get a response for $qC, check if $qfThreadID gives us a result.
+ if (m_curr_pid == LLDB_INVALID_PROCESS_ID && ostype == llvm::Triple::UnknownOS)
+ std::vector<lldb::tid_t> thread_ids;
> How does checking the "ostype" with unknown help us to determine if this is an OS where pid == tid? What if the user makes their target with:
> (lldb) target create --arch x86_64-pc-linux ...
> Then this code doesn't trigger?
In this case the target we are connected to is a bare-iron which does not support qC packet. Here pid == tid and only way to get this is using qfThreadID. If arch is likely to be unset during many of these calls then we need to find alternate way to implement this.
More information about the lldb-commits