[Lldb-commits] [PATCH] D11816: Allow dosep.py to print full output of dotest.py, even when dotest succeeds.

Chaoren Lin via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 10 10:22:06 PDT 2015

chaoren added a comment.

Zach, there were two more comments since the LGTM.

Comment at: test/dosep.py:1
@@ -1,2 +1,2 @@
-#!/usr/bin/env python
+#!/usr/bin/env python
chaoren wrote:
> I think you added a <U+FEFF> character here. Could you please double check before submitting?
Please remove the byte-order-mark that your editor added. 

Comment at: test/dosep.py:95
@@ -79,1 +94,3 @@
+def update_progress(test_name, result):
     global output_lock, test_counter, total_tests
chaoren wrote:
> The order of `test_name` and `result` here is different from the invocation.
The order of test_name and result here is different from the invocation.


More information about the lldb-commits mailing list