[Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

[Ed Maste via lldb-commits]

On 10 August 2015 at 05:13,  <Sagar.Thakur at imgtec.com> wrote:
>
>
> Hi Ed,
>
> We do not require to handle e_void case in GetData() as we have already
> checked if bytes_size greater than zero.
>>
>>     136    bool
>>     137    Scalar::GetData (DataExtractor &data, size_t limit_byte_size)
>> const
>>     138    {
>>     139        size_t byte_size = GetByteSize();
>>     140        static float f_val;
>>     141        static double d_val;
>> ->142         if (byte_size > 0)
>>     143        {
>
> Should I still add a case for e_void to clear the warnings?

We should clear the warnings, even though in in this case we can't
reach the switch statement if m_type is e_void as you say. It's
probably worth a brief comment on the case though.