[Lldb-commits] [PATCH] D11751: [lldb-mi] Simplify MICmnMIOutOfBandRecord implementation.
Bruce Mitchener
bruce.mitchener at gmail.com
Tue Aug 4 03:38:24 PDT 2015
brucem created this revision.
brucem added reviewers: abidh, ki.stfu.
brucem added a subscriber: lldb-commits.
* Remove extraneous members that were just storing temporary
values.
* OutOfBand_e parameters don't need to be const as they are
scalars.
* Switch from a map with CMIUtilString values to using a mapping
function. This uses a switch statement which will generate
a warning if a new result class is added.
* Make BuildAsyncRecord a static function rather than a private
member function so that we can construct the result text
correctly and avoid having extra stuff in the header.
http://reviews.llvm.org/D11751
Files:
tools/lldb-mi/MICmnMIOutOfBandRecord.cpp
tools/lldb-mi/MICmnMIOutOfBandRecord.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11751.31315.patch
Type: text/x-patch
Size: 11408 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150804/804e98e5/attachment.bin>
More information about the lldb-commits
mailing list