[Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

Jim Ingham jingham at apple.com
Mon Aug 3 11:36:29 PDT 2015

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This looks fine.  Please add a comment to the declaration of GetWatchpointHitAddress.  The meaning is really only explained in StopInfo.cpp, and I don't think the name is clear enough (we would say the watchpoint was NOT hit if the WatchpointHitAddress didn't equal the set address) to stand without some clarification.  Other than that it looks good.



More information about the lldb-commits mailing list