[Lldb-commits] [PATCH] D11431: Convert ScriptInterpreters to being first-class plugins

[Greg Clayton]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

A few unused things to remove and a reformat of a constructor and this is good to go!


================
Comment at: include/lldb/API/SBCommandInterpreter.h:100-102
@@ -99,2 +99,5 @@
     EventIsCommandInterpreterEvent (const lldb::SBEvent &event);
+
+    static void
+    InitializeScriptInterpreter();
     
----------------
Remove unused definition

================
Comment at: source/API/SBCommandInterpreter.cpp:11
@@ -10,2 +10,3 @@
 #include "lldb/lldb-types.h"
+
 #include "lldb/Core/SourceManager.h"
----------------
Discard this change

================
Comment at: source/Interpreter/CommandInterpreter.cpp:105-121
@@ -106,24 +104,19 @@
 
-CommandInterpreter::CommandInterpreter
-(
-    Debugger &debugger,
-    ScriptLanguage script_language,
-    bool synchronous_execution
-) :
-    Broadcaster (&debugger, CommandInterpreter::GetStaticBroadcasterClass().AsCString()),
-    Properties(OptionValuePropertiesSP(new OptionValueProperties(ConstString("interpreter")))),
-    IOHandlerDelegate (IOHandlerDelegate::Completion::LLDBCommand),
-    m_debugger (debugger),
-    m_synchronous_execution (synchronous_execution),
-    m_skip_lldbinit_files (false),
-    m_skip_app_init_files (false),
-    m_script_interpreter_ap (),
-    m_command_io_handler_sp (),
-    m_comment_char ('#'),
-    m_batch_command_mode (false),
-    m_truncation_warning(eNoTruncation),
-    m_command_source_depth (0),
-    m_num_errors(0),
-    m_quit_requested(false),
-    m_stopped_for_crash(false)
+CommandInterpreter::CommandInterpreter(Debugger &debugger, ScriptLanguage script_language, bool synchronous_execution)
+    : Broadcaster(&debugger, CommandInterpreter::GetStaticBroadcasterClass().AsCString())
+    , Properties(OptionValuePropertiesSP(new OptionValueProperties(ConstString("interpreter"))))
+    , IOHandlerDelegate(IOHandlerDelegate::Completion::LLDBCommand)
+    , m_debugger(debugger)
+    , m_synchronous_execution(synchronous_execution)
+    , m_skip_lldbinit_files(false)
+    , m_skip_app_init_files(false)
+    , m_script_interpreter_sp()
+    , m_command_io_handler_sp()
+    , m_comment_char('#')
+    , m_batch_command_mode(false)
+    , m_truncation_warning(eNoTruncation)
+    , m_command_source_depth(0)
+    , m_num_errors(0)
+    , m_quit_requested(false)
+    , m_stopped_for_crash(false)
 
----------------
Reformat. Please don't do the comma at the beginning of a line. 


http://reviews.llvm.org/D11431