[Lldb-commits] [PATCH] D11586: Make DWARF at_comp_dir symbolic links configurable via plugin.symbol-file.dwarf.comp-dir-symlink-paths setting.

[Oleksiy Vyalov]

ovyalov added inline comments.

================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:341-344
@@ +340,6 @@
+        const bool is_global_setting = true;
+        PluginManager::CreateSettingForProcessPlugin(debugger,
+                                                     GetGlobalPluginProperties()->GetValueProperties(),
+                                                     ConstString ("Properties for the dwarf symbol file plug-in."),
+                                                     is_global_setting);
+    }
----------------
clayborg wrote:
> We need a new SymbolFile based version of PluginManager::CreateSettingForProcessPlugin():
> 
> ```
> PluginManager::CreateSettingForSymbolFilePlugin(...)
> ```
> 
> Please create this function and have the setting name be "symbol-file".
My bad - copied from ProcessGDBRemote. Fixed.


http://reviews.llvm.org/D11586