[Lldb-commits] [PATCH] D11586: Make DWARF at_comp_dir symbolic links configurable via plugin.process.dwarf.symlink-paths setting.

[Greg Clayton]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

We need a new "symbol-file" plug-in category. Copy how we did it for "process" and add one for "symbol-file". The setting should be "plugin.symbol-file.dwarf.symlink-paths". See inlined comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:118
@@ +117,3 @@
+    {
+        { "symlink-paths" , OptionValue::eTypeFileSpecList, true,  0 ,   nullptr, nullptr, "DWARF AT_comp_dir symbolic links." },
+        {  nullptr        , OptionValue::eTypeInvalid     , false, 0,    nullptr, nullptr, nullptr }
----------------
Is this limited only the DW_AT_comp_dir? Then we should make the setting title clearer. Should this be "comp-dir-symlink-paths"? Then the description should be  a bit more verbose: "If the DW_AT_comp_dir matches any of these paths the symbolic links will be resolved at DWARF parse time."

================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:341-344
@@ +340,6 @@
+        const bool is_global_setting = true;
+        PluginManager::CreateSettingForProcessPlugin(debugger,
+                                                     GetGlobalPluginProperties()->GetValueProperties(),
+                                                     ConstString ("Properties for the dwarf symbol file plug-in."),
+                                                     is_global_setting);
+    }
----------------
We need a new SymbolFile based version of PluginManager::CreateSettingForProcessPlugin():

```
PluginManager::CreateSettingForSymbolFilePlugin(...)
```

Please create this function and have the setting name be "symbol-file".


http://reviews.llvm.org/D11586