[Lldb-commits] [PATCH] D11570: Escape variable creation error messages.
Ilia K
ki.stfu at gmail.com
Tue Jul 28 23:32:45 PDT 2015
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
================
Comment at: tools/lldb-mi/MICmdCmdVar.cpp:258
@@ -257,3 +257,3 @@
strErrMsg = CMIUtilString::Format(MIRSRC(IDS_CMD_ERR_VARIABLE_CREATION_FAILED), m_strExpression.c_str());
- const CMICmnMIValueConst miValueConst(strErrMsg);
+ const CMICmnMIValueConst miValueConst(strErrMsg.Escape());
CMICmnMIValueResult miValueResult("msg", miValueConst);
----------------
I believe we should also escape quotes, isn't it?
Use:
```
const CMICmnMIValueConst miValueConst(strErrMsg.Escape(true /* vbEscapeQuotes */));
```
http://reviews.llvm.org/D11570
More information about the lldb-commits
mailing list