[Lldb-commits] [lldb] r243448 - Remove eNewThreadMessage from FreeBSD process monitor

[Ed Maste]

Author: emaste
Date: Tue Jul 28 11:57:36 2015
New Revision: 243448

URL: http://llvm.org/viewvc/llvm-project?rev=243448&view=rev
Log:
Remove eNewThreadMessage from FreeBSD process monitor

FreeBSD thread information is updated after stop - we do not use a
message for thread creation.

Modified:
    lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
    lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h
    lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp?rev=243448&r1=243447&r2=243448&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp Tue Jul 28 11:57:36 2015
@@ -412,10 +412,6 @@ FreeBSDThread::Notify(const ProcessMessa
         CrashNotify(message);
         break;
 
-    case ProcessMessage::eNewThreadMessage:
-        ThreadNotify(message);
-        break;
-
     case ProcessMessage::eExecMessage:
         ExecNotify(message);
         break;
@@ -623,12 +619,6 @@ FreeBSDThread::CrashNotify(const Process
                                                          message.GetFaultAddress())));
 }
 
-void
-FreeBSDThread::ThreadNotify(const ProcessMessage &message)
-{
-    SetStopInfo (lldb::StopInfoSP(new POSIXNewThreadStopInfo(*this)));
-}
-
 unsigned
 FreeBSDThread::GetRegisterIndexFromOffset(unsigned offset)
 {

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h?rev=243448&r1=243447&r2=243448&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h Tue Jul 28 11:57:36 2015
@@ -125,7 +125,6 @@ protected:
     void SignalNotify(const ProcessMessage &message);
     void SignalDeliveredNotify(const ProcessMessage &message);
     void CrashNotify(const ProcessMessage &message);
-    void ThreadNotify(const ProcessMessage &message);
     void ExitNotify(const ProcessMessage &message);
     void ExecNotify(const ProcessMessage &message);
 

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp?rev=243448&r1=243447&r2=243448&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp Tue Jul 28 11:57:36 2015
@@ -272,7 +272,7 @@ ProcessFreeBSD::SendMessage(const Proces
         break;
 
     case ProcessMessage::eNewThreadMessage:
-        assert(0 && "eNewThreadMessage unexpected on FreeBSD");
+        llvm_unreachable("eNewThreadMessage unexpected on FreeBSD");
         break;
 
     case ProcessMessage::eExecMessage:
@@ -620,19 +620,6 @@ ProcessFreeBSD::RefreshStateAfterStop()
         if (log)
             log->Printf ("ProcessFreeBSD::%s(), message_queue size = %d, pid = %" PRIi64, __FUNCTION__, (int)m_message_queue.size(), tid);
 
-        if (message.GetKind() == ProcessMessage::eNewThreadMessage)
-        {
-            if (log)
-                log->Printf ("ProcessFreeBSD::%s() adding thread, tid = %" PRIi64, __FUNCTION__, message.GetChildTID());
-            lldb::tid_t child_tid = message.GetChildTID();
-            ThreadSP thread_sp;
-            thread_sp.reset(CreateNewFreeBSDThread(*this, child_tid));
-
-            Mutex::Locker lock(m_thread_list.GetMutex());
-
-            m_thread_list.AddThread(thread_sp);
-        }
-
         m_thread_list.RefreshStateAfterStop();
 
         FreeBSDThread *thread = static_cast<FreeBSDThread*>(