[Lldb-commits] [PATCH] D11482: Add target setting to have the language follow the frame's CU.
Jim Ingham
jingham at apple.com
Mon Jul 27 11:24:01 PDT 2015
> On Jul 27, 2015, at 11:09 AM, Dawn Perchik <dawn+llvm at burble.org> wrote:
>
> dawn requested a review of this revision.
> dawn added a comment.
>
> I need guidance due to conflicting directions from Greg and Sean. Sean wants to be able to evaluate ObjC++ by default always, hence this feature was made optional. Greg feels the frame can be used for the language without an option, but that will break the ability to evaluate ObjC++ anytime.
Just to be clear... Sean doesn't have a DESIRE to have the expression parser use ObjC++ anytime the language is a C family language. Rather he MUST right now, because the expression parser uses features of C++ to capture values. We could switch to using C++ in C/C++ situations, and ObjC++ in others, but there wasn't sufficient motivation to add that. Sometime when we get some spare cycles we'll try to relax the need for C++, and then we'll truly be able to follow the frame language. For now, we do "Want C -> get ObjC++", "Want ObjC -> get ObjC++" etc... But again, that is not a fundamental choice, it is an implementation necessity.
Jim
>
> See also:
> http://reviews.llvm.org/D11102 - eval in language of frame's CU and add C++ language option to ObjC so tests will still work.
> http://reviews.llvm.org/D11173 - rewrote test which tested ObjC types in C++ test case to be ObjC++ so test would still work.
>
> We can either go with this patch, or http://reviews.llvm.org/D11102 and http://reviews.llvm.org/D11173. I would choose this patch because it makes the behavior optional, and everyone is happy.
>
> Please advise. Thank you.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D11482
>
>
>
More information about the lldb-commits
mailing list