[Lldb-commits] [PATCH] D11498: Print reference values on one line.

[Chaoren Lin]

chaoren added a comment.

> I am assuming that your intent is:


Yep.

> a) a much better way would be to make FormatManager::ShouldPrintAsOneLiner() decide that a T& can be printed on one-line iff the referenced thing can


I though `ShouldPrintAsOneLiner` already does that for each of the < 50 children. The change around `bool print_oneline` is only refactoring for readability. The only difference is that `curr_ptr_depth` is not set to 1 so `ShouldPrintAsOneLiner` can actually get called.


http://reviews.llvm.org/D11498