[Lldb-commits] [PATCH] D11497: Change Socket::Read / Socket::Write to log to LOG_COMMUNICATION instead of LOG_HOST

[Zachary Turner]

Seems reasonable.  lgtm

On Fri, Jul 24, 2015 at 3:18 PM Jason Molenda <jmolenda at apple.com> wrote:

> jasonmolenda created this revision.
> jasonmolenda added a reviewer: zturner.
> jasonmolenda added a subscriber: lldb-commits.
> jasonmolenda set the repository for this revision to rL LLVM.
>
> I'm adding some new host logging to help diagnose problems of finding
> executable files or dSYMs, Greg suggested we should add it to the Host log
> channel.  Currently Socket::Read and Socket::Write are logging to Host
> which is super verbose.  He suggests that we should switch these over the
> Communication log channel instead.  Some of Socket.cpp is logging to
> LOG_CONNECTION already.  Zachary, any opinion on this?  I think you touched
> this most recently.  Not sure if you're using this logging yourself.
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D11497
>
> Files:
>   source/Host/common/Socket.cpp
>
> Index: source/Host/common/Socket.cpp
> ===================================================================
> --- source/Host/common/Socket.cpp
> +++ source/Host/common/Socket.cpp
> @@ -139,7 +139,7 @@
>      NativeSocket sock = kInvalidSocketValue;
>      Error error;
>
> -    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST));
> +    Log *log(lldb_private::GetLogIfAnyCategoriesSet
> (LIBLLDB_LOG_COMMUNICATION));
>      if (log)
>          log->Printf ("Socket::TcpConnect (host/port = %s)",
> host_and_port.data());
>
> @@ -632,7 +632,7 @@
>      else
>          num_bytes = bytes_received;
>
> -    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST |
> LIBLLDB_LOG_COMMUNICATION));
> +    Log *log(lldb_private::GetLogIfAnyCategoriesSet
> (LIBLLDB_LOG_COMMUNICATION));
>      if (log)
>      {
>          log->Printf ("%p Socket::Read() (socket = %" PRIu64 ", src = %p,
> src_len = %" PRIu64 ", flags = 0) => %" PRIi64 " (error = %s)",
> @@ -674,7 +674,7 @@
>      else
>          num_bytes = bytes_sent;
>
> -    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST));
> +    Log *log(lldb_private::GetLogIfAnyCategoriesSet
> (LIBLLDB_LOG_COMMUNICATION));
>      if (log)
>      {
>          log->Printf ("%p Socket::Write() (socket = %" PRIu64 ", src = %p,
> src_len = %" PRIu64 ", flags = 0) => %" PRIi64 " (error = %s)",
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150724/06dcecd1/attachment.html>