[Lldb-commits] [PATCH] D11150: [NativeProcessLinux] Integrate MainLoop

[Pavel Labath]

Hi,

On 24 July 2015 at 19:17, Chaoren Lin <chaorenl at google.com> wrote:
> Hi Pavel,
>
> I think this issue came back again.
>
> I tried on Nexus Player and Nexus 9 and `process kill` gives the error:
> ```
> Handle_k: failed to kill spawned pid <pid>, ignoring.
> ```
> from lldb-server.
Yes, the message right now is probably being printed unconditionally.
Since we don't have a reaper thread, it fails to detect that the
process has exited already. I've been meaning to fix that, but I kinda
forgot. I will do it on monday. Are you noticing any ill side effects,
or did you just see the message? I expect that the server should
behave fine in spite of that.

>
> I think it might be a good idea if we archived stdout/stderr from
> lldb-server too. Hopefully it'll be empty, but if we get errors like these,
> we'll have a log.

I think we should just replace all fprintf's with proper logging, to
make things consistent.

cheers,
pl