[Lldb-commits] [PATCH] D11473: Add option eTypeOptionHideEmptyAggregates.

[Enrico Granata]

granata.enrico added a comment.

The change itself seems fine, just a couple minor things:

- I have some ideas on what should happen if synthetic children fail to produce values for whatever reason. This change itself does not conflict with any of that, though, so it's good to go
- Is there going to be a flag to "type summary add" for setting your new flag, or is this only meant for internal formatters?
- How do you plan to test it?
- If anything, maybe replace Print with Expand, to get ShouldExpandEmptyAggregates(). We are indeed printing the aggregate, just not "expanding" it


http://reviews.llvm.org/D11473