[Lldb-commits] [PATCH] D11415: Add jstopinfo support to llgs

[Oleksiy Vyalov]

ovyalov accepted this revision.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:720
@@ +719,3 @@
+        // the info it needs.
+        if (m_debugged_process_sp->GetThreadAtIndex(1))
+        {
----------------
Nit: if (thread_index > 0)? In this case no to acquire NativeProcessProtocol::m_threads_mutex

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:723
@@ +722,3 @@
+            const bool threads_with_valid_stop_info_only = true;
+            JSONArray::SP threads_info_sp = GetJSONThreadsInfo(*m_debugged_process_sp,
+                                                               threads_with_valid_stop_info_only);
----------------
Could you check for threads_info_sp != nullptr?


http://reviews.llvm.org/D11415