[Lldb-commits] [lldb] r242875 - Fix warnings found by -Wextra-semi

Pavel Labath labath at google.com
Wed Jul 22 01:12:02 PDT 2015


Author: labath
Date: Wed Jul 22 03:12:01 2015
New Revision: 242875

URL: http://llvm.org/viewvc/llvm-project?rev=242875&view=rev
Log:
Fix warnings found by -Wextra-semi

patch by Eugene Zelenko.

Modified:
    lldb/trunk/include/lldb/Interpreter/CommandObject.h
    lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
    lldb/trunk/include/lldb/Target/ThreadPlan.h
    lldb/trunk/source/API/SBValueList.cpp
    lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
    lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h
    lldb/trunk/source/Target/LanguageRuntime.cpp
    lldb/trunk/tools/lldb-mi/MICmdArgSet.h
    lldb/trunk/tools/lldb-mi/MICmdData.h
    lldb/trunk/tools/lldb-mi/MICmdFactory.h
    lldb/trunk/tools/lldb-mi/MICmdInvoker.h
    lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.h
    lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h
    lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.h

Modified: lldb/trunk/include/lldb/Interpreter/CommandObject.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Interpreter/CommandObject.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Interpreter/CommandObject.h (original)
+++ lldb/trunk/include/lldb/Interpreter/CommandObject.h Wed Jul 22 03:12:01 2015
@@ -503,7 +503,7 @@ public:
         CommandObject (interpreter, name, help, syntax, flags) {}
 
     virtual
-    ~CommandObjectParsed () {};
+    ~CommandObjectParsed () {}
     
     virtual bool
     Execute (const char *args_string, CommandReturnObject &result);
@@ -514,7 +514,7 @@ protected:
              CommandReturnObject &result) = 0;
     
     virtual bool
-    WantsRawCommandString() { return false; };
+    WantsRawCommandString() { return false; }
 };
 
 class CommandObjectRaw : public CommandObject
@@ -529,7 +529,7 @@ public:
         CommandObject (interpreter, name, help, syntax, flags) {}
 
     virtual
-    ~CommandObjectRaw () {};
+    ~CommandObjectRaw () {}
     
     virtual bool
     Execute (const char *args_string, CommandReturnObject &result);
@@ -539,7 +539,7 @@ protected:
     DoExecute (const char *command, CommandReturnObject &result) = 0;
 
     virtual bool
-    WantsRawCommandString() { return true; };
+    WantsRawCommandString() { return true; }
 };
 
 

Modified: lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h (original)
+++ lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h Wed Jul 22 03:12:01 2015
@@ -62,7 +62,7 @@ public:
                            StringList &commands_help);
 
     virtual bool
-    WantsRawCommandString() { return false; };
+    WantsRawCommandString() { return false; }
 
     virtual int
     HandleCompletion (Args &input,

Modified: lldb/trunk/include/lldb/Target/ThreadPlan.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlan.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlan.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlan.h Wed Jul 22 03:12:01 2015
@@ -568,7 +568,7 @@ protected:
     //------------------------------------------------------------------
 
     virtual bool
-    DoWillResume (lldb::StateType resume_state, bool current_plan) { return true; };
+    DoWillResume (lldb::StateType resume_state, bool current_plan) { return true; }
 
     virtual bool
     DoPlanExplainsStop (Event *event_ptr) = 0;

Modified: lldb/trunk/source/API/SBValueList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBValueList.cpp?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/API/SBValueList.cpp (original)
+++ lldb/trunk/source/API/SBValueList.cpp Wed Jul 22 03:12:01 2015
@@ -39,7 +39,7 @@ public:
             return *this;
         m_values = rhs.m_values;
         return *this;
-    };
+    }
     
     uint32_t
     GetSize ()
@@ -297,5 +297,3 @@ SBValueList::ref ()
     CreateIfNeeded();
     return *m_opaque_ap.get();
 }
-
-

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.h (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.h Wed Jul 22 03:12:01 2015
@@ -63,7 +63,7 @@ protected:
     WriteFPR();
 
     virtual void*
-    GetGPRBuffer() { return nullptr; };
+    GetGPRBuffer() { return nullptr; }
 
     virtual size_t
     GetGPRSize() { return GetRegisterInfoInterface().GetGPRSize(); }
@@ -105,4 +105,3 @@ protected:
 } // namespace lldb_private
 
 #endif // #ifndef lldb_NativeRegisterContextLinux_h
-

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Wed Jul 22 03:12:01 2015
@@ -192,7 +192,7 @@ public:
         {
             for (uint32_t i = 0; i < e_num; ++i)
                 m_has[i] = false;
-        };
+        }
 
         void set_name (const std::string & name)
         {

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h Wed Jul 22 03:12:01 2015
@@ -19,10 +19,10 @@ namespace lldb_private {
 class DWARFDataExtractor : public lldb_private::DataExtractor
 {
 public:
-    DWARFDataExtractor() : DataExtractor(), m_is_dwarf64(false) { };
+    DWARFDataExtractor() : DataExtractor(), m_is_dwarf64(false) { }
 
     DWARFDataExtractor (const DWARFDataExtractor& data, lldb::offset_t offset, lldb::offset_t length) :
-      DataExtractor(data, offset, length), m_is_dwarf64(false) { };
+      DataExtractor(data, offset, length), m_is_dwarf64(false) { }
 
     uint64_t
     GetDWARFInitialLength(lldb::offset_t *offset_ptr) const;
@@ -43,4 +43,3 @@ protected:
 }
 
 #endif  // liblldb_DWARFDataExtractor_h_                                 
-

Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h Wed Jul 22 03:12:01 2015
@@ -199,7 +199,7 @@ private:
             dqo_target_queue = UINT16_MAX;
             dqo_target_queue = UINT16_MAX;
             dqo_priority = UINT16_MAX;
-        };
+        }
 
         bool
         IsValid ()

Modified: lldb/trunk/source/Target/LanguageRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/LanguageRuntime.cpp?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/source/Target/LanguageRuntime.cpp (original)
+++ lldb/trunk/source/Target/LanguageRuntime.cpp Wed Jul 22 03:12:01 2015
@@ -34,7 +34,7 @@ public:
     }
 
     virtual
-    ~ExceptionSearchFilter() {};
+    ~ExceptionSearchFilter() {}
 
     bool
     ModulePasses (const lldb::ModuleSP &module_sp) override
@@ -493,6 +493,3 @@ LanguageRuntime::CreateExceptionSearchFi
 {
     return m_process->GetTarget().GetSearchFilterForModule(NULL);
 }
-
-
-

Modified: lldb/trunk/tools/lldb-mi/MICmdArgSet.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgSet.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgSet.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgSet.h Wed Jul 22 03:12:01 2015
@@ -52,7 +52,7 @@ class CMICmdArgSet : public CMICmnBase
         virtual bool GetValid(void) const = 0;
         virtual bool Validate(CMICmdArgContext &vwArgContext) = 0;
 
-        /* dtor */ virtual ~IArg(void){};
+        /* dtor */ virtual ~IArg(void){}
     };
 
     // Typedefs:

Modified: lldb/trunk/tools/lldb-mi/MICmdData.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdData.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdData.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdData.h Wed Jul 22 03:12:01 2015
@@ -26,7 +26,7 @@ struct SMICmdData
         , bCmdValid(false)
         , bCmdExecutedSuccessfully(false)
         , bMIOldStyle(false)
-        , bHasResultRecordExtra(false){};
+        , bHasResultRecordExtra(false){}
 
     MIuint id;                               // A command's unique ID i.e. GUID
     CMIUtilString strMiCmdToken;             // The command's MI token (a number)

Modified: lldb/trunk/tools/lldb-mi/MICmdFactory.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdFactory.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdFactory.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdFactory.h Wed Jul 22 03:12:01 2015
@@ -50,7 +50,7 @@ class CMICmdFactory : public CMICmnBase,
         // virtual CMICmdBase *         CreateSelf( void ) = 0;             // Not possible as require a static creator
         // function in the command class, here for awareness
 
-        /* dtor */ virtual ~ICmd(void){};
+        /* dtor */ virtual ~ICmd(void){}
     };
 
     // Methods:

Modified: lldb/trunk/tools/lldb-mi/MICmdInvoker.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdInvoker.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdInvoker.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdInvoker.h Wed Jul 22 03:12:01 2015
@@ -63,7 +63,7 @@ class CMICmdInvoker : public CMICmnBase,
         virtual const CMIUtilString &GetMIResultRecordExtra(void) const = 0;
         virtual bool HasMIResultRecordExtra(void) const = 0;
 
-        /* dtor */ virtual ~ICmd(void){};
+        /* dtor */ virtual ~ICmd(void){}
     };
 
     // Methods:

Modified: lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.h Wed Jul 22 03:12:01 2015
@@ -37,7 +37,7 @@ class ICallback
   public:
     virtual void Delete(SMICmdData &vCmd) = 0;
 
-    /* dtor */ virtual ~ICallback(void){};
+    /* dtor */ virtual ~ICallback(void){}
 };
 
 //++ ============================================================================

Modified: lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h Wed Jul 22 03:12:01 2015
@@ -52,7 +52,7 @@ template <typename T> class ISingleton
     virtual bool Initialize(void) = 0;
     virtual bool Shutdown(void) = 0;
     //
-    /* dtor */ virtual ~ISingleton(void){};
+    /* dtor */ virtual ~ISingleton(void){}
 };
 
 } // namespace MI

Modified: lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.h?rev=242875&r1=242874&r2=242875&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.h (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.h Wed Jul 22 03:12:01 2015
@@ -34,7 +34,7 @@ class CMIUtilThreadMutex
 {
     // Methods:
   public:
-    /* ctor */ CMIUtilThreadMutex(void){};
+    /* ctor */ CMIUtilThreadMutex(void){}
     //
     void
     Lock(void); // Wait until mutex can be obtained
@@ -46,7 +46,7 @@ class CMIUtilThreadMutex
     // Overrideable:
   public:
     // From CMICmnBase
-    /* dtor */ virtual ~CMIUtilThreadMutex(void){};
+    /* dtor */ virtual ~CMIUtilThreadMutex(void){}
 
     // Attributes:
   private:





More information about the lldb-commits mailing list