[Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.
Ilia K
ki.stfu at gmail.com
Tue Jul 21 20:53:28 PDT 2015
ki.stfu added inline comments.
================
Comment at: test/tools/lldb-mi/variable/main.cpp:63-65
@@ -63,3 +63,4 @@
const char16_t u16a[] = u"hello";
const char32_t *u32p = U"hello";
const char32_t u32a[] = U"hello";
+
----------------
paulmaybee wrote:
> ki.stfu wrote:
> > please replace these strings with your improved strings (lines 67-72).
> So you want me to remove the original tests instead of adding new tests?
>
Yes. Your tests are better and there is no reason to have both sets of tests.
http://reviews.llvm.org/D11371
More information about the lldb-commits
mailing list