[Lldb-commits] [PATCH] D11296: [LLGS] Get rid of the stdio forwarding thread

Pavel Labath labath at google.com
Tue Jul 21 06:23:03 PDT 2015


labath marked an inline comment as done.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:970
@@ +969,3 @@
+                log->Printf("GDBRemoteCommunicationServerLLGS::%s Stopping stdio forwarding as communication returned status %d (error: %s)", __FUNCTION__, status, error.AsCString());
+            m_stdio_handle_up.reset();
+            return;
----------------
ovyalov wrote:
> If eventually lldb-server will be fully single-threaded then then it's ok to keep MainLoop as-is - since anyway monitor will be part of main thread.
I have committed this with the (previously reverted) commit which removes NativeProcessLinux monitor thread. This makes lldb-server single threaded.


Repository:
  rL LLVM

http://reviews.llvm.org/D11296







More information about the lldb-commits mailing list