[Lldb-commits] [PATCH] D11052: [lldb-mi] Simplify MICmnMIResultRecord implementation.

Ilia K ki.stfu at gmail.com
Tue Jul 21 02:32:44 PDT 2015


ki.stfu added a comment.

Looks good, but how about returning NULL before exiting from MapResultClassToResultClassText?


================
Comment at: tools/lldb-mi/MICmnMIResultRecord.cpp:35
@@ +34,3 @@
+    }
+}
+
----------------
here:
```
  assert(0 && "unknown CMICmnMIResultRecord::ResultClass_e");
  return NULL;
```


http://reviews.llvm.org/D11052







More information about the lldb-commits mailing list